holoviews icon indicating copy to clipboard operation
holoviews copied to clipboard

Use colorcet register_cmap

Open hoxbro opened this issue 1 year ago • 1 comments

When https://github.com/holoviz/colorcet/pull/90 is merged and released, it will remove the DeprecationWarning.

hoxbro avatar Sep 28 '22 14:09 hoxbro

Codecov Report

Merging #5460 (7e8c66b) into master (07ef9b3) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
+ Coverage   88.09%   88.12%   +0.03%     
==========================================
  Files         301      301              
  Lines       61991    62096     +105     
==========================================
+ Hits        54608    54722     +114     
+ Misses       7383     7374       -9     
Impacted Files Coverage Δ
holoviews/plotting/mpl/__init__.py 81.61% <100.00%> (-0.14%) :arrow_down:
holoviews/core/options.py 82.44% <0.00%> (-0.36%) :arrow_down:
holoviews/__init__.py 72.22% <0.00%> (ø)
holoviews/core/data/pandas.py 93.30% <0.00%> (ø)
holoviews/tests/core/test_apply.py 100.00% <0.00%> (ø)
holoviews/tests/plotting/bokeh/test_sankey.py 100.00% <0.00%> (ø)
...iews/tests/plotting/matplotlib/test_elementplot.py 100.00% <0.00%> (ø)
holoviews/plotting/bokeh/element.py 88.87% <0.00%> (+0.01%) :arrow_up:
holoviews/core/util.py 86.08% <0.00%> (+0.02%) :arrow_up:
...loviews/tests/plotting/matplotlib/test_renderer.py 98.70% <0.00%> (+0.02%) :arrow_up:
... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 28 '22 15:09 codecov-commenter

Either need to have a fallback or need to pin the new version of colorcet.

philippjfr avatar Oct 02 '22 11:10 philippjfr

The register_cmap function has been in colorcet as a "normal" matplotlib import for a long time, and the updated register_cmap function added in https://github.com/holoviz/colorcet/pull/90 should be backward compatible. So I don't think a pin is necessary, but correct me if I'm wrong.

hoxbro avatar Oct 03 '22 07:10 hoxbro

Ah did not know it was already there before the version. Ignore me then.

philippjfr avatar Oct 03 '22 09:10 philippjfr

Colorcet has now been released with that PR merged there. Merging here too, thanks!

jlstevens avatar Oct 04 '22 09:10 jlstevens