holoviz-topics
[WIP] Multichannel Timeseries Example
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).
Just noting that for the multichan.ipynb, I'm having to use an Overlay instead of e.g. curves_overlay = hv.NdOverlay(curves, 'Channel', sort=False)... I wonder if this impacts performance at all
Note: Check to ensure that the resultant downsampled data pyramid doesn't ever live entirely in memory prior to getting written to disk.
Note: find better principled way to determine factors for creating the data pyramids..
The following doesn't work as the number of channels scales
FACTORS = list(np.array([1, 2, 4, 8, 16, 32, 64, 128, 256]) ** (len(ts_ds["channel"]) // 4))
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
@maximlt , I'm guessing you'd prefer if I link to the video clips instead of including them in the repo? I guess we need to make a youtube channel finally
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Looks like the embedded static images which have HTML styling don't appear on the dev site so I guess I wouldn't expect them to work for the main set.
UPDATE: FIXED
I was hoping the using a 'hide_input' cell tag would all for rendering the video output without the code cell.. for some reason I thought we had enabled this in the past..? maybe for datashader configurations?
UPDATE: FIXED
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Looks like the embedded static images which have HTML styling don't appear on the dev site so I guess I wouldn't expect them to work for the main set.
I commented on that here https://github.com/holoviz-topics/examples/pull/418#discussion_r1838298630. You're right, images wrapped in a div (or anything else I guess) won't work on the site because Sphinx doesn't detect the img source and as such it doesn't get included in the output.
I was hoping the using a 'hide_input' cell tag would all for rendering the video output without the code cell.. for some reason I thought we had enabled this in the past..? maybe for datashader configurations?
It's hide-input, and I'd assume it would work? But my question really is, do we need the IPython code or can't this just be pure HTML in a Markdown cell?
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
You're right, images wrapped in a div (or anything else I guess) won't work on the site because Sphinx doesn't detect the img source and as such it doesn't get included in the output.
unwrapped images from divs
It's hide-input, and I'd assume it would work? But my question really is, do we need the IPython code or can't this just be pure HTML in a Markdown cell?
I don't think video is supported with HTML in a markdown cell
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
@maximlt, I think I've addressed everything identified up until now. Sorry for not seeing some of the previous review comments until recently. Thanks for the epic review!
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.
Thanks for the epic review!
We got well over-trained to do this last year with the NF SDF grant! Thanks for adjusting the example based on our feedback, it's such a cool one. It should totally be in the Featured section, except that I think keeping 8 examples there sounds reasonable and I didn't which one to remove, so that's for later :) Merging, congrats!
I agree that 8 is the max for that section. It's a very tough call; those are all very cool examples, but if I think about what they demonstrate, this example covers things not included there at all, so I do think it should bump something out. I'd guess we should replace Exoplanets in that group, given that it's not currently showing any plots (which is maybe an error?).
