examples icon indicating copy to clipboard operation
examples copied to clipboard

Gapminders

Open maximlt opened this issue 2 years ago • 2 comments

  • [x] Handle the data explicitly instead of loading it dynamically from an external URL directly from the notebook

Given the search I did last summer Gapminders was the only project that was downloading data dynamically from a notebook (e.g. pd.read_csv(external_url)). It should instead have its data better defined. I'm suggesting adding data as a data source in the downloads section of its anaconda-project.yml file. I would also be good to add a small test dataset in test_data/.

(If the data isn't heavy at all it could be added to the /data subfolder in the project directly).

maximlt avatar Jan 10 '23 13:01 maximlt

That all sounds good, thanks!

jbednar avatar Jan 20 '23 19:01 jbednar

In my latest PR, I removed downloading from the notebook and added a test dataset.

jtao1 avatar Jun 05 '24 04:06 jtao1