tryorama icon indicating copy to clipboard operation
tryorama copied to clipboard

crates/trycp_server/Cargo.lock was removed, breaking downstream builds

Open steveej opened this issue 6 months ago • 0 comments

it was removed in https://github.com/holochain/tryorama/commit/1e94fe2ac1c76e70412ae39c6388d0059b286259

the trycp_server crate has been part of the workspace for over two years, since: https://github.com/holochain/tryorama/commit/8affc336770804027f90a3f2d62d6a229d3b0257

hence i'm not sure if the removing of its own Cargo.lock was intentional.

the CI tests explicit change into the crate directory for testing:

https://github.com/holochain/tryorama/blob/a44a536b57421737e36eaf51003b78f6b6acd563/build-trycp.sh#L5-L6

things i'm going to double-check and will update this issue with:

  • [ ] does the top-level lockfile generally have the trycp_server dependencies?
  • [ ] is the top-level lockfile updated currently up to date with the trycp_server Cargo.toml?

as a follow-up to keep this repo consistent the following item is relevant:

  • [ ] is the top-level lockfile updated regularly?

steveej avatar Aug 07 '24 07:08 steveej