scaffolding icon indicating copy to clipboard operation
scaffolding copied to clipboard

Template sweep -- fix bugs in Vue and Lit

Open pdaoust opened this issue 2 years ago • 2 comments

I don't claim this is a thorough sweep that catches all bugs, but it does catch all bugs discovered via following the Getting Started Guide but choosing Lit and Vue instead of Svelte for the templating engine.

pdaoust avatar Oct 03 '23 22:10 pdaoust

@pdaoust Same with this one, please can it target develop? Then would you be willing to go through and comment on the PR with a description of what is being changed/fixed so I can do some testing?

I'm happy reviewing the code but I don't know the repo well enough to understand what's changing without having a conversation about it if that's okay! :)

ThetaSinner avatar Nov 02 '23 15:11 ThetaSinner

This is now ready for review and can be merged when ready

ThetaSinner avatar Nov 03 '23 16:11 ThetaSinner

@pdaoust, allow me to close this PR since it is stale at the moment and most of the changes made here have long been addressed

c12i avatar Sep 25 '24 10:09 c12i

Sure @c12i . Are there any fixes that haven't already been made? Should I do a new PR with those?

pdaoust avatar Oct 01 '24 17:10 pdaoust

Thanks @pdaoust, I don't think there are any changes at the moment, I inadvertently addressed them while transitioning the templates to the new styling.

c12i avatar Oct 02 '24 07:10 c12i