holochain-rust icon indicating copy to clipboard operation
holochain-rust copied to clipboard

Bounded

Open freesig opened this issue 5 years ago • 4 comments

PR summary

Adds bounded channels to prevent memory building up in unbounded channels

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • [ ] if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

freesig avatar Mar 19 '20 12:03 freesig

The sim2h side looks awesome! nice work async-ifying everything!

neonphog avatar Mar 19 '20 15:03 neonphog

When I test manually I see lots of problems with not being able to get a lock on state in the action loop. Also you can't ctrl-c out of the conductor any more.

zippy avatar Mar 19 '20 15:03 zippy

Using spawn_blocking for the for the crossbeam_channel blocking sends actually makes this playground work - although I at least get three would-block thread panics - so maybe 1000 is more than it can keep up with?

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=579de08c026ae6005e1c0ffdb319be54

neonphog avatar Mar 19 '20 15:03 neonphog

Oh yeh I haven't figured out how to get the shutdown to happen on this properly yet. Maybe test it if and then if it's helpful I can look at how to do that.

freesig avatar Mar 25 '20 02:03 freesig