holochain-rust icon indicating copy to clipboard operation
holochain-rust copied to clipboard
verified publisher icon holochain

the hashing algorithm should not be hardcoded to SHA2256

Open thedavidmeister opened this issue 7 years ago • 5 comments

the golang version allowed the hashing algorithm to be configurable in the DNA

currently the rust version is hardcoded to SHA2256 in the source chain (e.g. Entry and Header)

this should be correctly parameterised so that the DNA configuration works correctly

thedavidmeister avatar Jul 03 '18 11:07 thedavidmeister

relevant discussion https://github.com/holochain/holochain-rust/pull/102#discussion_r199810826

screen shot 2018-07-04 at 10 38 12 am

thedavidmeister avatar Jul 04 '18 00:07 thedavidmeister

@zippy annoyingly, it looks like github doesn't auto link comments when you leave them on a PR :(

https://github.com/holochain/holochain-rust/pull/102#discussion_r199811929

thedavidmeister avatar Jul 04 '18 00:07 thedavidmeister

This is probably cross-repo issues where we had one number in org and another in holochain-rust?

zippy avatar Jul 04 '18 21:07 zippy

nah, same repo, but the comment was part of a PR review

thedavidmeister avatar Jul 04 '18 23:07 thedavidmeister

[F8-enhancement] M4-core P7-nicetohave

jamesray1 avatar Dec 19 '19 05:12 jamesray1