holo icon indicating copy to clipboard operation
holo copied to clipboard

WIP: BIER extension for OSPFv3

Open nrybowski opened this issue 10 months ago • 1 comments

This PR adds BIER extensions for OSPFv3 as defined by draft-ietf-bier-ospfv3-extensions-07. The TLV format is the same as for OSPFv2 hence implementing RFC8444 on the basis laid down by this PR should be straightforward.

It relies on #10 for the addition of the BIER YANG model.

TODO

  • [x] Add non-mpls encapsulation sub-sub-TLV as defined by draft-ietf-bier-lsr-non-mpls-extensions-03
  • [x] Encode BIER encapsulation sub-sub-TLV
  • [ ] Handle BierCfgUpdate and BierCfgEncapUpdate events
  • [ ] Enforce constraints on incoming BIER TLVs
  • [ ] Implement BIER control-plane (BIFT computation, ...)
  • [ ] Add unit test for BIER TLVs

nrybowski avatar Apr 08 '24 09:04 nrybowski

Rebase on 980694896ed393dc66ea4b8b53bd9dcdaa247f1d

nrybowski avatar Aug 02 '24 14:08 nrybowski

Codecov Report

Attention: Patch coverage is 40.70796% with 134 lines in your changes missing coverage. Please review.

Project coverage is 63.07%. Comparing base (c370052) to head (81a0ab1). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
holo-ospf/src/ospfv3/lsdb.rs 4.87% 39 Missing :warning:
holo-ospf/src/northbound/configuration.rs 16.66% 35 Missing :warning:
holo-ospf/src/bier.rs 0.00% 21 Missing :warning:
holo-ospf/src/southbound/tx.rs 12.50% 14 Missing :warning:
holo-ospf/src/events.rs 0.00% 8 Missing :warning:
holo-ospf/src/packet/tlv.rs 89.33% 8 Missing :warning:
holo-ospf/src/instance.rs 0.00% 6 Missing :warning:
holo-ospf/src/route.rs 60.00% 2 Missing :warning:
holo-ospf/src/lsdb.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   63.40%   63.07%   -0.34%     
==========================================
  Files         178      179       +1     
  Lines       29704    30018     +314     
==========================================
+ Hits        18833    18933     +100     
- Misses      10871    11085     +214     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 14 '24 14:08 codecov[bot]

I'm not sure to understand why the BGP test suite is failing (https://github.com/holo-routing/holo/actions/runs/10468201712/job/28988566615?pr=16), I can't reproduce locally ..

nrybowski avatar Aug 20 '24 08:08 nrybowski

The PR is still missing some integration tests and sanity check upon BIER TLV reception but it should be ready for a first review.

nrybowski avatar Aug 20 '24 08:08 nrybowski

Rebase on c3700523d4360a59e520cbb1f194f9a5eaea14af to fix CI failure on BGP tests.

nrybowski avatar Sep 09 '24 08:09 nrybowski