holo
holo copied to clipboard
WIP: BIER extension for OSPFv3
This PR adds BIER extensions for OSPFv3 as defined by draft-ietf-bier-ospfv3-extensions-07. The TLV format is the same as for OSPFv2 hence implementing RFC8444 on the basis laid down by this PR should be straightforward.
It relies on #10 for the addition of the BIER YANG model.
TODO
- [x] Add non-mpls encapsulation sub-sub-TLV as defined by draft-ietf-bier-lsr-non-mpls-extensions-03
- [x] Encode BIER encapsulation sub-sub-TLV
- [ ] Handle BierCfgUpdate and BierCfgEncapUpdate events
- [ ] Enforce constraints on incoming BIER TLVs
- [ ] Implement BIER control-plane (BIFT computation, ...)
- [ ] Add unit test for BIER TLVs
Rebase on 980694896ed393dc66ea4b8b53bd9dcdaa247f1d
Codecov Report
Attention: Patch coverage is 40.70796%
with 134 lines
in your changes missing coverage. Please review.
Project coverage is 63.07%. Comparing base (
c370052
) to head (81a0ab1
). Report is 14 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 63.40% 63.07% -0.34%
==========================================
Files 178 179 +1
Lines 29704 30018 +314
==========================================
+ Hits 18833 18933 +100
- Misses 10871 11085 +214
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm not sure to understand why the BGP test suite is failing (https://github.com/holo-routing/holo/actions/runs/10468201712/job/28988566615?pr=16), I can't reproduce locally ..
The PR is still missing some integration tests and sanity check upon BIER TLV reception but it should be ready for a first review.
Rebase on c3700523d4360a59e520cbb1f194f9a5eaea14af to fix CI failure on BGP tests.