fastapi-permissions icon indicating copy to clipboard operation
fastapi-permissions copied to clipboard

__acl__ was never awaited

Open Tears opened this issue 4 years ago • 4 comments

Hi,

First of all, thanks for making this library. I'm on my first FastAPI project right now and we're really liking the library so far.

However, we do run into a little problem when using dynamically generated ACL's. Our app is connected via Tortoise ORM to a PostgreSQL-database, from which we are generating the ACL's in the models. We are required to approach the database async, so we need to make the ACL-function in the model async as well. Like this:

async def __acl__(self) -> List:

    acl = []

    # Do stuff with the database here, and append them as rules in the ACL
    # Example:
    async for attendee in self.parent_activity.get_attendees():
        acl.append((Allow, f"user:{attendee.user.id}", "view"))
   

    return acl

However, when checking the object this ACL is attached to via the Permission-function, we are greeted with the following error:

RuntimeWarning: coroutine 'Activity.__acl__' was never awaited

(Activity is the model name)

Could you maybe implement an await for the ACL's? Like I said, this is my first project with FastAPI so maybe I'm using it all wrong, but we are stuck with this now. Thanks in advance!

Tears avatar Nov 21 '20 15:11 Tears

Hi,

probably you did nothing wrong. I never used an async db access for this - so it's seems to be a case I haven't considered.

I have an idea on how to solve this, I "just" need some time to get to this and I'd like to ask you for some patience.

holgi avatar Nov 25 '20 18:11 holgi

Hi, thanks for your reply. Could you describe your idea on how to solve this? Maybe I could take a look then and submit a PR.

Tears avatar Nov 28 '20 14:11 Tears

Is there any progress that was made @holgi ? I too, am hitting this bug with motor/beanie

jsenecal avatar Mar 07 '22 06:03 jsenecal

Running into the same issue as well, will post any protentional solutions I find

Gadgetguycj avatar Sep 18 '23 20:09 Gadgetguycj