Haojian Wu
Haojian Wu
It should not be hard to support this API (and the `FloatingGamepadTextInputDismissed_t ` event).
I have limited free time, but I will try to add support for it in the next release.
This API is not exposed in Greenworks yet.
Although this is still a draft, it should be ready for an initial round of review. Any feedback or suggestions would be greatly appreciated. @AaronBallman @cor3ntin @erichkeane @ilya-biryukov
> I did a light pass of the 1st 1/4 of this or so. The smuggling back and forth to raw-encoding seems strange? WHy are we doing that here? In...
> Sorry for being dumb... how are we getting away with only storing 40 bits? Does that not just artificially limit our source-location size for statements? And, frankly, then our...
Closing it in favor of #147292
> Any reason for not annotating the rest of the constructors? Note that the ArrayRef is already annotated as gsl::Pointer, so constructor for the gsl::Owner already works without the lifetimebound...
> Yes, indeed. For example, in `AST/ast-dump-for-range-lifetime.cpp` we move from: `-MaterializeTemporaryExpr {{.*}} 'C':'P2718R0::C' xvalue extended by Var {{.*}} '__range1' 'C &&'` to: `-MaterializeTemporaryExpr {{.*}} 'C':'P2718R0::C' xvalue`. At a first look...
> I have debug the issue, seems we cannot move the __range variable check to the start of checkExprLifetimeImpl, we may missing extending lifetime of temporaries. Ah, that makes sense...