mastering-react icon indicating copy to clipboard operation
mastering-react copied to clipboard

Updating how to create history

Open intrepion opened this issue 10 years ago • 1 comments

I made this pull request because of a transpiling error after installing react-router:

Error: Cannot find module 'react-router/lib/BrowserHistory'

I found a solution in a comment of one of their issues.

https://github.com/rackt/react-router/issues/1455#issuecomment-138295614

I hope these pull requests aren't annoying... I'm just trying to fix the errors I see while I'm going through your packtpub videos which are really nice! thanks for doing them!

intrepion avatar Oct 24 '15 18:10 intrepion

@intrepion no, this is great feedback!

The issues are mostly due to packages going from beta to final with a bunch of changes in between. Hopefully the concepts I discuss are conveyed well regardless of these minor issues.

hojberg avatar Oct 24 '15 19:10 hojberg