Fix for a build error on modern MSVC

Open v-ein opened this issue 6 months ago • 1 comments

name: Pull Request about: Create a pull request to help us improve title: Fix for a build error on modern MSVC assignees: ''

Description: GitHub is having issues with building DPG for Windows. In particular, the compiler can't resolve an ambiguous abs() call where the argument is float (and abs is an integer function). While we could simply change start to float, I preferred to keep the current logic because I'm going to add another PR in future that will fix more issues in the loading indicator, so no need to change the behavior now. I'm only helping the compiler choose the right abs overload :).

Concerning Areas: None.

Jun 20 '25 08:06 v-ein

Now I wonder. This PR has not been merged yet but when I opened #2521 the Windows build completed successfully. Could it be that this PR is no longer necessary?

Jun 21 '25 13:06 v-ein