DearPyGui icon indicating copy to clipboard operation
DearPyGui copied to clipboard
verified publisher icon hoffstadt

Themes improvement

Open v-ein opened this issue 11 months ago • 2 comments

name: Pull Request about: Create a pull request to help us improve title: Several fixes on theme internals assignees: @hoffstadt

Description: This PR is difficult to test as it fixes internal-looking issues within mvThemes.cpp.

  • Fixes the use of smart pointers and gets rid of circular references.
  • Removes the useless all_item_theme_component (it is never really used by push/pop because of mvAppItemType::All conditions in them).
  • Fixes pop order for components.

Concerning Areas: None.

v-ein avatar Feb 08 '25 21:02 v-ein

Is this ready?

hoffstadt avatar May 30 '25 16:05 hoffstadt

Techincally yes, it is ready. I've just added a minor change that should prevent potential undefined behavior (which currently would not happen anyway, it's just to make code more robust).

I see on the Checks tab that the Windows build fails in ImPlot. It's not related to this PR but I think we need to fix it anyway. Will take a look a bit later. It builds fine on my local Windows machine.

v-ein avatar Jun 03 '25 11:06 v-ein