DearPyGui icon indicating copy to clipboard operation
DearPyGui copied to clipboard

Update add_date_picker Summary

Open mzimm003 opened this issue 1 year ago • 5 comments

Fix typo for add_date_picker.


name: Pull Request about: Improve docs. title: Update add_date_picker Summary assignees: @Pcothren


Closes #2447

Description:

The summary of the method add_date_picker currently reads "Adds a data picker." Update changes this to read "Adds a date picker."

Concerning Areas:

None

mzimm003 avatar Dec 13 '24 02:12 mzimm003

Thanks for catching this typo! Unfortunately this PR is not going to fix it because dearpygui.py is generated automatically from multiple sources. The original string is in mvAppItem.cpp. After you fix it, build DPG and run DearPyGuiSandbox.exe - it will re-generate the API files - there are three of them, including dearpygui.py. These files, even though they are generated, need to be committed together with mvAppItem.cpp.

Or, alternatively, we can keep this PR open as a reminder, and one day I'll fix it myself :) (easy for me since I have everything set up for building it on my PC).

v-ein avatar Jun 21 '25 19:06 v-ein

Thanks for explaining! I believe I've followed your direction. Build was noted as successful. After, I ran "BuildSandboxLinux.sh" instead as I am on Ubuntu (couldn't actually find "DearPyGuiSandbox.exe"), but I hope this is equivalent.

I don't see the three files you mention, so perhaps I still messed something up. I'll keep looking into it in case I missed something.

mzimm003 avatar Jun 23 '25 00:06 mzimm003

I don't see the three files you mention, so perhaps I still messed something up.

Yep, you still need to run the sandbox. I don't have Linux at the moment and can't check it, but it should be somewhere in the build folder (probably cmake-build-local in the project root) and is probably named DearSandbox (see this wiki page).

Also, no need to commit scripts/BuildSandboxLinux.sh (if you're using git commit -a it will add the script automatically due to changed access mode -- be careful with that -a flag, better use explicit git add).

v-ein avatar Jun 23 '25 05:06 v-ein

I believe I've finally figured it out. Thank you for your patience.

mzimm003 avatar Jun 28 '25 05:06 mzimm003

We'll merge it after release 2.1.

v-ein avatar Jul 03 '25 18:07 v-ein