dkb-visa icon indicating copy to clipboard operation
dkb-visa copied to clipboard

from_date greater than 3 years ago gives initially displayed transactions and does not create an error.

Open inktrap opened this issue 9 years ago • 4 comments

I tested this via dkbweb.py which calls dkb.py, so this should apply to dkb.py as well.

If you specify a from_date like 1.1.1970, you won't get an error from mechanize. But it triggers another issue: The csv export will only contain the initially visible transactions because the date is not submittable. This means that the page won't update and the csv-file won't be generated with the new dates.

I "fixed" this for myself by fetching all the transactions from the last year every time and later I filter the results via sets. See: https://github.com/inktrap/dkb-export/blob/master/dkbweb.py#L215. Btw.: I also checked that BASEURL is an https-url. :)

Edit: Just to clarify: The allowed from_date is set server side and constant.

inktrap avatar Jan 09 '16 09:01 inktrap

Hm, I am not sure I understand. A quick test revealed that changing the from_date does work for me. I guess there may be DKB-side limits how long you can go back in time...? So, either I misunderstand or there must be some other difference between your test and mine. :)

Regarding the HTTPS-enforcement: As the URL is hardcoded and not user-changable, I think it is OK to leave it as-is.

hoffie avatar May 29 '16 19:05 hoffie

Ok, now I see -- the web interface only returns about one year of data, if I see it correctly. Yes, this is a limitation, but I do not see any way to overcome this besides integrating locally "archived" data.

hoffie avatar May 29 '16 19:05 hoffie

well, at least the error handling could be improved on the side of dkb-visa. If I set 01.01.1970 in the current version and submit, the UI automatically sets to the first date possible, 01.06.2015, and tells with a popup field: "Die Eingabe wurde systemseitig angepasst."

okurz avatar May 30 '16 06:05 okurz

Yes, that is the behaviour I ment: dkb falls back to the date where you they have data. So the user of the script should be informed that they don't get what they asked for.

Just FYI: In my fork I set the based on todays date minus two years and 11 months. that way I get all the transactions. Then I wrote some code to deduplicate the transactions.

Excerpts from Oliver Kurz's message of 2016-05-29 23:01:30 -0700:

well, at least the error handling could be improved on the side of dkb-visa. If I set 01.01.1970 in the current version and submit, the UI automatically sets to the first date possible, 01.06.2015, and tells with a popup field: "Die Eingabe wurde systemseitig angepasst."


You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/hoffie/dkb-visa/issues/7#issuecomment-222417297

inktrap avatar May 30 '16 08:05 inktrap