gulp-msbuild icon indicating copy to clipboard operation
gulp-msbuild copied to clipboard

Please make "targets" optional

Open eric-914 opened this issue 6 years ago • 0 comments

I've just discovered that these two options are incompatible with each other:

%msbuild% /t:Publish /p:DeployOnBuild=true ==> There is a circular dependency in the target dependency graph involving target "Publish"

This works: %msbuild% /t:Publish

And this works: %msbuild% /p:DeployOnBuild=true /p:PublishProfile=MyProfile.pubxml

Notice that the /target option isn't part of this. But msbuild-command-builder.js (line 11) requires a targets option, and will error if undefined.

I have found this as a workaround for the time being: %msbuild% /t:Build /p:DeployOnBuild=true /p:PublishProfile=MyProfile.pubxml

The fix, I believe, is to change line 11 to: if (options.targets) { args.push('/target:' + options.targets.join(';')); }

eric-914 avatar Jul 03 '18 15:07 eric-914