Erik Söhnel
Erik Söhnel
@moltar no the image is generated during one of the test runs that has the configured `NODE_VERSION_FOR_PREVIEW`: https://github.com/moltar/typescript-runtime-type-benchmarks/blob/b9a326534d2ae7b57a7416a1e22d5ba31f8e0de5/benchmarks/helpers/main.ts#L10 Forgot to update this to 18 in my node-version update. I'll create...
@mmamedel thx for catching the outdated preview. > I quoted "top 3" because that's the SVG title, but it actually shows top 4. It shows the top 3 packages and...
> Question: how hard would it be to order the top 3 preview by result instead of by name? Not sure any more but I think I tried to sort...
> @hoeck Do you any to include the update to preview on this pr or leave it to another one? @mmamedel no I will do that in a separate PR
Could generate that table as part of the benchmark runs and also add it it as filter checkboxes to the interactive graph. Any ideas on which features are relevant? I'd...
> Yeah, that list is pretty much what I was thinking. Maps well to your solution with splitting the suites. > > I am also interested in "JSON Schema support",...
Also, deepkit seems to require at least node v14 (tried that locally and it worked): ``` /home/runner/work/typescript-runtime-type-benchmarks/typescript-runtime-type-benchmarks/node_modules/@deepkit/type/dist/cjs/src/reflection/reflection.js:923 type.visibility = prop.visibility ?? type_1.ReflectionVisibility.public; ^ SyntaxError: Unexpected token '?' at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1728:14)...
@BasixKOR I you like, you can also run the tests locally with `npm run test`, you'll then see that the `parseStrict` case test is failing for deepkit: ``` deepkit ✓...
> I understood in a completely opposite way joy I'll remove the strict ones, thanks for the suggestion! Indeed that was worded quite ambiguously, I meant removing the benchmark case...
> I am in favour of dropping Node v12! :+1: okay I'll create a PR that drops node 12, after merging, this PR can then be rebased and deepkit tests...