Richard Höchenberger

Results 611 comments of Richard Höchenberger

I just ran into this issue while playing with the new `anonymize_dataset()` function: event trigger values changed in the anonymized data, which lead me to this issue. Here's a MWE...

> I'm afraid the only way to fix this is to allow `read_raw_bids` to return an `event_id` dict which can then be passed to `events_from_annotations()` Or we add this to...

> @agramfort I don't believe I have write access here? I've just granted you write access to this repo, can you push here now?

> Stupid question: how do I fetch this PR? ```shell git fetch --all git switch simplify_fpath ```

> If you have maintainer rights (I think you don't right now) you can also push to alex's fork directly I've granted @adam2392 `write` rights, I thought this would suffice...

I've resolved the merge conflict. Looking into the emptyroom stuff now.

Moving to 0.10 milestone

I believe there was still something missing, I don't remember. I can try to take a look within the next couple of days

> It'd be quite nice also to fill the `EEGReference` metadata in BIDS 👍

Hello @weiyongxu and thanks for reporting this issue! You're right, we should utilize the values even if no trial types are provided. FWIW, the specification declares the entire trial_type column...