Simon Cross
Simon Cross
Some thoughts / questions: * What about `HPyDup_None(ctx)`? * Does the `ctx` get a new function pointer to replace each `h_` handle pointer? If not, what happens instead?
Additional idea from #250: We could define a list of constants via an enum or defines and then have one function `HPy_GetType(ctx, HPY_BOOL_TYPE)` that returns a new handle to the...
Current status: On hold, pending an investigation by @nulinspiratie on what's needed to make a larger fix of issues reported by mypy.
> Current status: On hold, pending an investigation by @nulinspiratie on what's needed to make a larger fix of issues reported by mypy. Update: @nulinspiratie said he made some progress...
See #633 for progress on fixing the MyPy errors.
#633 is close to being merged, so I'll close this much more minimal fix.
Discussed at today's TSC meeting. We'd like to see the following changes before reviewing again: - rename `QuantumMeasurementGeneric` to `QuantumCallExpression` - add support for calling `defcals` that accept multiple qubits...
I'm -1 on allowing Qobjs to be mutated like this. It's a big footgun for ourselves and users and the benefit of being able to mutate list items in place...
Thanks @fmayo96. Question: Should the `einsum` function be in `dimensions.py`? And should it be internal or exposed via the public API? It looks generically useful but what specific use cases...
I had a discussion with @nwlambert and if ensuring correctness is an issue, I suggest implementing both of the following: - Keep the performant implementation and move the simple displacement...