Mail icon indicating copy to clipboard operation
Mail copied to clipboard

Replace hard coded value by constant

Open vonglasow opened this issue 10 years ago • 1 comments

https://github.com/hoaproject/Mail/pull/27/files#diff-b518b20b529a6cf4ff44c6fba63eee4fR273

In this code, we use a lot a hard coded value which represent smtp return code and other stuff. This is not so explicit it could be better to have a constant related.

What do you think?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

vonglasow avatar Aug 28 '15 09:08 vonglasow

Hello :-),

As said on IRC: “This is just codes, this is hard to associate a name to them”. But we can try by re-reading all the RFCs, thoughts?

Hywan avatar Aug 28 '15 09:08 Hywan