Irc icon indicating copy to clipboard operation
Irc copied to clipboard

Why a "mention" message was not treated like a message ?

Open marmotz opened this issue 10 years ago • 8 comments

IMHO, you should fire a mention AND a message event and maybe specify when a message is a mentionned message, too.

marmotz avatar Jan 01 '15 22:01 marmotz

Actually a mention IS a message, another event is just used to be able to catch it as a specific message (because it is) and display it in another way than a "simple" message.

Jir4 avatar Jan 02 '15 11:01 Jir4

Thank you to be agree with me : mention IS a message. So I want to catch all messages in "message" event, even if I was mentioned ☺

marmotz avatar Jan 02 '15 12:01 marmotz

Ok now i see exactly what you want ^^

Jir4 avatar Jan 02 '15 13:01 Jir4

You can see my reimplementation of Client::_run method and especially my rewrite of PRIVMSG messages: https://github.com/marmotz/WallIrc/blob/master/src/Irc/Client.php#L147-L178

Although, I added nick, notice, part and quit management.

marmotz avatar Jan 03 '15 17:01 marmotz

@marmotz Please, make a PR.

Hywan avatar Jan 04 '15 14:01 Hywan

with all my code ?

marmotz avatar Jan 04 '15 15:01 marmotz

@marmotz You said it's done. Well, do a PR :-).

Hywan avatar Jan 04 '15 15:01 Hywan

Still up?

Hywan avatar Oct 14 '16 19:10 Hywan