Compiler icon indicating copy to clipboard operation
Compiler copied to clipboard

Remove dependency to `ext/ctype`

Open Hywan opened this issue 6 years ago • 4 comments

It has been noted in https://github.com/hoaproject/Compiler/pull/93#discussion_r232647557 that hoa/compiler depends ext/ctype just because of a single call to ctype_digit in a non-critical path. I think it's a good idea to remove this dependency :-).

Hywan avatar Nov 12 '18 13:11 Hywan

Is it worth it? This extension is built-in by default, unless you disabled it on purpose: https://secure.php.net/manual/en/ctype.installation.php.

composer.json should require it, though.

unkind avatar Nov 13 '18 02:11 unkind

We only use it once, and for a minor feature. It should be easy to write a workaround.

Hywan avatar Dec 05 '18 10:12 Hywan

Doesn't make sense to me - ctype is implicit extension.

Majkl578 avatar Jan 07 '19 10:01 Majkl578

Keep extension since it comes with default php installation.

flip111 avatar Jan 25 '19 14:01 flip111