Compiler
Compiler copied to clipboard
Remove dependency to `ext/ctype`
It has been noted in https://github.com/hoaproject/Compiler/pull/93#discussion_r232647557 that hoa/compiler
depends ext/ctype
just because of a single call to ctype_digit
in a non-critical path. I think it's a good idea to remove this dependency :-).
Is it worth it? This extension is built-in by default, unless you disabled it on purpose: https://secure.php.net/manual/en/ctype.installation.php.
composer.json should require it, though.
We only use it once, and for a minor feature. It should be easy to write a workaround.
Doesn't make sense to me - ctype is implicit extension.
Keep extension since it comes with default php installation.