Compiler icon indicating copy to clipboard operation
Compiler copied to clipboard

Remove $nodeId from Token rule definition.

Open SerafimArts opened this issue 7 years ago • 1 comments

The third argument to the Token rule is not needed and is not required at runtime or for some other things. We can get rid of it.

new Token($id, $name, $nodeId, $unificationId, $kept);
//                    ^^^^^^^ - excess

SerafimArts avatar Aug 15 '18 12:08 SerafimArts

I read the code, and right now, I found no useful case where the $nodeId is used in the constructor. It is always set to null. I guess we can remove it!

https://github.com/hoaproject/Compiler/issues/85#issuecomment-403390651

Should be easy to fix this. Suggest adding issues to

https://up-for-grabs.net/#/

https://github.com/MunGell/awesome-for-beginners#php

https://www.firsttimersonly.com/

flip111 avatar Jan 25 '19 14:01 flip111