Compiler icon indicating copy to clipboard operation
Compiler copied to clipboard

Adjust testing state, enhance exception context, fix PCRE issue

Open ohader opened this issue 5 years ago • 7 comments

  • TravisCI configuration for getting tests "green" - there's more to do in terms of resolving inter-package dependencies and their version constraints ("dependency hell")
  • fixes issue #111
  • fixes issue #112
  • fixes issue #113

ohader avatar Oct 06 '20 12:10 ohader

Coverage Status

Coverage remained the same at 0.0% when pulling 14a4ca7261f02bd87f320170762d771c3de15312 on ohader:master into c620f44deff0b4c2d0c27560a3b0f5e7e376e001 on hoaproject:master.

coveralls avatar Oct 06 '20 12:10 coveralls

Coverage Status

Coverage remained the same at 0.0% when pulling 14a4ca7261f02bd87f320170762d771c3de15312 on ohader:master into c620f44deff0b4c2d0c27560a3b0f5e7e376e001 on hoaproject:master.

coveralls avatar Oct 06 '20 12:10 coveralls

IF this gets stuck, there's this fork. I'll be happy to review a PR.

I already did PHP 7.4 there IIRC.

sanmai avatar Oct 06 '20 12:10 sanmai

IF this gets stuck, there's this fork. I'll be happy to review a PR.

I already did PHP 7.4 there IIRC.

Thx & good to know... reading other announcements of this project currently not being actively maintained would lead to the conclusion this PR is laying here forever. I'm a fan of try to centralize those things with the upstream repository.

Let's see, maybe there are also some possibilities (really) merging your compatibility changes into this repository...

ohader avatar Oct 06 '20 12:10 ohader

Well, if you could get a hand on that sweet merge button here, we can certainly try something. But, tbh, I was primarily concerned with jms/serializer using this package, which is no more...

sanmai avatar Oct 06 '20 12:10 sanmai

I'm a fan of try to centralize those things with the upstream repository.

I'd love that too, but considering that last PR was merged here in 2018, I'd say we'll have a tough luck here.

sanmai avatar Oct 06 '20 13:10 sanmai

Well, if you could get a hand on that sweet merge button here, we can certainly try something. But, tbh, I was primarily concerned with jms/serializer using this package, which is no more...

I see, I also considered using a "hard-wired" parser, but then found this project again... However I'm better in using (a)BNF-like terms to describe formats (a complicated format in my particular case) I gave it a try with hoa/compiler. Let's see 😃

ohader avatar Oct 06 '20 13:10 ohader