magento2-Ho_Templatehints icon indicating copy to clipboard operation
magento2-Ho_Templatehints copied to clipboard

Published 20 hours ago • verified publisher icon ho-nl

Hyva Theme compatibility?

Open itaymesh opened this issue 2 years ago • 2 comments

Greetings, Does this module compatible with the Hyva theme? Thanks Itay

itaymesh avatar Feb 19 '23 09:02 itaymesh

Hi itaymesh,

I was just looking into this because I had the same question. I tried it and it's not. This is because hints.js depends on requirejs, jquery, etc.

Since the javascript part isn't that complex, maybe it's possible to rewrite it to vanilla js and load it in a phtml or something. It will be faster and compatible.

jeroenbalk-adwise avatar Feb 24 '23 14:02 jeroenbalk-adwise

This module is to be used for Magento based theming if I'm not mistaken. Of course you are free to create a PR that creates some compatibility as long as it keeps working in a vanilla Magento installation.

PascalBrouwers avatar Feb 24 '23 14:02 PascalBrouwers