[BUG] Player compare does not react to adjusted skills

[leschmuh]

Describe the bug On the player compare tab you would want to compare players at the same form level. But I realized that there are no changes in the ratings, no matter waht skills (form or any other you adjust).

To Reproduce Steps to reproduce the behavior:

1. Go to "Player analyis" tab
2. Go to "Player compare" tab
3. Select any player(s) you want on the left hand side and on the right hand side set any skill to any level that is different from the actual skill of the selected player(s) (form "passable" is the default setting which should be intended to equal out form differences for all players; so the default setting should work with any player whose form ist different from passable)
4. Click "Compare"
5. Select any of the compared players at the bottom half
6. On the bottom right hand side "Original" and "Changed" values are identical, no matter what skills you had adjusted before and how much they differ from the actaul skills in the selected player

Screenshots

Platform information:

• OS: Windows 11
• Version 23H2 (22631.4037)
• Found and reproduced both in HO Version 8.0 and 8.1 - don't know about earlier versions...

[wsbrenk]

Can reproduce the error. First fix now shows different values for changed and original column but. Calculation of the originals takes subskills of the player into account whereas subskills in the changed column are always zero.

I think even for unchanged skills we should use the original subskill in calculation - @leschmuh what do you think?

[leschmuh]

Thanks for handling this!

I totally agree, changed skills should be set "equal", i.e. no subskills, and unchanged skills should keep the subskill.