HattrickOrganizer icon indicating copy to clipboard operation
HattrickOrganizer copied to clipboard

[FEATURE] Market Value is empty

Open masterpatje opened this issue 3 years ago • 11 comments

Describe the bug In previous version of hattrick (before H.O. 3.0 I think) there was a market value. Is it possible to re-establish this feature in HO 7.0?

Screenshots image

masterpatje avatar Jul 22 '22 20:07 masterpatje

@masterpatje i don't know if that was a duplicate of the tsi column. i would remove it.

wsbrenk avatar Jul 23 '22 07:07 wsbrenk

I know that the indicated column would represent the market value in M€. It would hold an indication of the value that could be seen in 'transfer comparison'. I don't know if it was exact that value as shown in hattrick or based on an algorithm.

masterpatje avatar Jul 30 '22 14:07 masterpatje

                //TSI löste Marktwert ab!
                ele = (Element) root.getElementsByTagName("TSI").item(0);
                hash.put("MarketValue", (XMLManager.getFirstChildNodeValue(ele)));

this change is from before 2018. in transfer module similar changes are found.

i don't have an idea what to put into this column.

wsbrenk avatar Dec 29 '22 13:12 wsbrenk

maybe we could implement something compareble to hattricks transfer search

wsbrenk avatar Dec 29 '22 13:12 wsbrenk

That would be a good idea. This is a field that can be of good use. I know that I used it also in earlier versions to do sorting on players that are highly valuable on the market. It can be field used for determining which players are best to be trained or to trade them more optimal.

masterpatje avatar Dec 29 '22 16:12 masterpatje

Hattrick implemented a change. On each increase or decrease of skill a new market value is calculated. It is actually an indication of how much worth a player is on the current transfer market.

Is this information available in a form for you as developers when downloading the hrf files?

As a rule. The market value field can then be filled with the last known value in M€.

masterpatje avatar Jan 15 '24 08:01 masterpatje

Is this information available in a form for you as developers when downloading the hrf files?

There doesn't seem to be any info on market value in the player details API. There isn't any recent change in the Changelog indicating changes in that area either.

We can keep an eye out and see if this change propagates to CHPP in the coming weeks. Do you have a link to the announcement?

tychobrailleur avatar Jan 16 '24 08:01 tychobrailleur

Would it be possible to do a change request via GM-users or directly to staff? Do you have experience with it? I once asked for making the training estimation available in the application and I got a message that they would pass it a long. I can do this, but maybe more chance if it comes from a CHPP-partner.


Van: Sébastien Le Callonnec @.> Verzonden: dinsdag 16 januari 2024 09:04 Aan: ho-dev/HattrickOrganizer @.> CC: masterpatje @.>; Mention @.> Onderwerp: Re: [ho-dev/HattrickOrganizer] [FEATURE] Market Value is empty (Issue #1594)

Is this information available in a form for you as developers when downloading the hrf files?

There doesn't seem to be any info on market value in the player details APIhttps://www86.hattrick.org/Community/CHPP/NewDocs/File.aspx?name=playerdetails. There isn't any recent change in the Changeloghttps://www86.hattrick.org/Community/CHPP/NewDocs/ indicating changes in that area either.

We can keep an eye out and see if this change propagates to CHPP in the coming weeks.

— Reply to this email directly, view it on GitHubhttps://github.com/ho-dev/HattrickOrganizer/issues/1594#issuecomment-1893237301, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYKSKGWYHHFSKY5422LTUMDYOYYBBAVCNFSM54MXUUNKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBZGMZDGNZTGAYQ. You are receiving this because you were mentioned.Message ID: @.***>

masterpatje avatar Jan 17 '24 13:01 masterpatje

image

These values are not part of any chpp-api file until today

wsbrenk avatar Feb 18 '24 14:02 wsbrenk

there is already a change request on the chpp development list: https://www83.hattrick.org/Forum/Read.aspx?t=17373595&n=2&v=0

wsbrenk avatar Feb 18 '24 14:02 wsbrenk

Combine with https://github.com/ho-dev/HattrickOrganizer/issues/1910. Same request.

masterpatje avatar Feb 18 '24 17:02 masterpatje