[BUG] Matches - Several Features | Clean Up Ladder Competition Matches |

[masterpatje]

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

1. Go to 'Matches'

Screenshots Screenshot 1: selection filter is the same

Screenshot 2: "ladder competition" matches (exclude option)

• I wish to have the option to exclude "ladder competition" matches from the selection of matches
• In general I would like to select the type of matches to be included, for example select all cup matches and all league matches. Now I can only select on or the other.

Platform information:

• OS: Windows 10
• Version 7.0.350

Additional context Additional problem: Ladder competition matches are not deleted on clean up:

Result: No ladder competition matches are deleted. [Debug] DBCleanupTool: Removing old matches: removeDateOwnMatches=null, removeDateOwnFriendlies=null, removeDateOtherMatches=2022-07-19 12:03:34.797, removeDateOtherFriendlies=2022-07-19 12:03:34.797 [Debug] DBCleanupTool: Removed 0/42 matches from DB!

[wsbrenk]

screenshot 1: the tagged entries are not identical. the first one should show your cup and qualification matches too.

[wsbrenk]

screenshot 2: show my competition matches should deliver approximately the desired. (league + cup + qualification)

[wsbrenk]

@masterpatje i'm with you, that selection by combobox items is not the best choice. i would suggest to improve this in HO7. maybe we could do it with check boxes.

[wsbrenk]

concerning cleanup: "Other matches" seems to be misleading. it does mean matches of other teams, not other match types.

[wsbrenk]

improvements of db cleanup should also be part of HO7 development.

[masterpatje]

Fine with me to tackle the features in 7.0. And your comments where clear.

[tychobrailleur]

I started some work on this, in particular in the Matches tab. For the DB cleanup tool, I have clarified the labels, and I am also planning on adding matches count (right now not super pretty, but I will improve layout):

One thing I observed, which I didn't expect is that when deleting other people's matches, this affected some of my own players ratings:

This doesn't quite make sense to me, what do you think, @wsbrenk?

[wsbrenk]

@tychobrailleur absolute agreement - this should not happen. but i can't reproduce it for now.

[tychobrailleur]

This is the current state of this:

A bit more work to perform the various deletes, and I should be ready to create a PR soon.

[tychobrailleur]

One thing I observed, which I didn't expect is that when deleting other people's matches, this affected some of my own players ratings:

That's the last thing to solve. This can be reproduced by starting HO, and selected the first element in the list of HRF files. I am looking into this.