flutter_shimmer icon indicating copy to clipboard operation
flutter_shimmer copied to clipboard

Show/hide shimmer effect

Open subzero911 opened this issue 4 years ago • 5 comments

Expected behaviour - when enabled: false, hide shimmer effect but show children Current behaviour - stops the animation. Because of it I have to create 2 trees - a shimmer tree with fake widgets and a tree with actual widgets image

Please consider using enabled to show/hide shimmering, and period: 0 is for stopping the animation

subzero911 avatar Apr 17 '21 08:04 subzero911

Or I'd suggest to deprecate parameter enabled as non-obvious, and introduce visible: true/false and animation: true/false instead.

subzero911 avatar Apr 19 '21 09:04 subzero911

@subzero911 I vote for that, really confusing and make you double the widgets.

CripyIce avatar May 26 '21 19:05 CripyIce

any updates on this?

adschi avatar Aug 26 '21 11:08 adschi

this feature would be too much. stop animation doesn't make much sense.

mdmota avatar Mar 04 '22 20:03 mdmota

this feature would be too much. stop animation doesn't make much sense.

I am agree with this point. Then let's return to the idea I suggested in a start post. Rename enabled to visible and make use it to show/hide shimmer effect and those people who wants to stop animation for some reason will use period: 0.

subzero911 avatar Dec 08 '22 18:12 subzero911