flutter_shimmer icon indicating copy to clipboard operation
flutter_shimmer copied to clipboard

Published 20 hours ago • verified publisher icon hnvn

Feature/shimmer presentation state

Open BohdanNikoletti opened this issue 6 years ago • 8 comments
trafficstars

Start to review this pull request after adopting https://github.com/hnvn/flutter_shimmer/pull/13

BohdanNikoletti avatar Sep 29 '19 13:09 BohdanNikoletti

Idea behind this PR is adopt ShimmerState. With ShimmerState we can support multiple states of Shimmer Widget. For example in case of my App. I need to pause shimmer animation in some point. After completely return shimmer effect and simply draw child instead. Important: I 've tested it manually. Double check pls.🙏🏻

BohdanNikoletti avatar Oct 03 '19 11:10 BohdanNikoletti

I think my solution can be combined with solution in. https://github.com/hnvn/flutter_shimmer/pull/12

BohdanNikoletti avatar Oct 03 '19 19:10 BohdanNikoletti

Sorry for late replay, I am too busy with other repositories, I will try to look at this feature at the weekend

hnvn avatar Oct 16 '19 14:10 hnvn

Please add tests considering each state of the shimmer and check with expect

WilliamCunhaCardoso avatar Aug 28 '20 12:08 WilliamCunhaCardoso

Please add tests considering each state of the shimmer and check with expect

Ok. Going to add tests.

BohdanNikoletti avatar Aug 28 '20 13:08 BohdanNikoletti

Please add tests considering each state of the shimmer and check with expect

Added some tests in latest PR. Could you take a look at what do you think?

BohdanNikoletti avatar Aug 31 '20 14:08 BohdanNikoletti

Also, make some changes and introduce an animation controller provider. To make AnimationController testable.

BohdanNikoletti avatar Aug 31 '20 14:08 BohdanNikoletti

Please add tests considering each state of the shimmer and check with expect

Added some tests in latest PR. Could you take a look at what do you think?

Looks good to me. We must wait for @hnvn

WilliamCunhaCardoso avatar Aug 31 '20 14:08 WilliamCunhaCardoso