Håvard M. Ottestad

Results 288 comments of Håvard M. Ottestad

Some relevant discussion: https://github.com/eclipse-rdf4j/rdf4j/discussions/5037

The json-ld side is a bit different. There we are depending on two completely different libraries. The only issue that would occur if you depend on both is that you...

> Happy to rebase that onto develop and change the target branch to develop, if needed. Yeah, this needs to target the develop branch. Btw. Have you considered supporting VALUES...

I'll have to take a look at the code to understand how things are handled at the moment.

``` public QueryResponse search(SolrQuery query) throws SolrServerException, IOException { int nDocs; if (maxDocs > 0) { nDocs = maxDocs; } else { long docCount = client.query(query.setRows(0)).getResults().getNumFound(); nDocs = Math.max((int) Math.min(docCount,...

Looks like this here is where we extract variables from the SPARQL query: https://github.com/eclipse-rdf4j/rdf4j/blob/755a631efbc95df52e4e590984ab9b0049d4fef5/core/sail/lucene-api/src/main/java/org/eclipse/rdf4j/sail/lucene/QuerySpecBuilder.java#L450 So that can be extended to add `ROWS`. And then follow the code up to see...

We can't do the same with `public synchronized TopDocs search(Query query) throws IOException {}` since the query object doesn't have any info about the number of rows or equivalent. So...

The parser/serializer relies on Java SPI. Adding the corresponding dependency in maven should automatically register as a service.

Try adding rdf4j-client as a second dependency.