Harrison Healey

Results 170 comments of Harrison Healey

Of the E2E test failures, I think `tests/integration/channels/messaging/autocomplete_shown_each_channel_spec.js` is the only that is caused by this PR. The rest of those that I tested locally seem to either pass for...

I added "Awaiting Submitter Action" because there's something that seems to be weird here about how the autocomplete behaves when the textbox is focused. Most of the logic in here...

It's failing because `en.json` is out of order because of the new string you added, but since we missed it during reviews, I should be able to just fix it...

I'm trying to understand exactly what broke here to cause this to happen. If I have this right, we made this change to schema_admin_settings.tsx which made the defaults stop having...

Ah, I see. I thought the bug was about some settings being stuck with a false value for some reason

Here's the link again to the design to save a few clicks https://www.figma.com/file/i86bHWcB68HMiaJNoVxmsq/Image-Preview-Modal?type=design&node-id=125-0&mode=design&t=KGOuz7Dvks2UYJ2s-0

I wonder if it would be possible to have the zoomable image container always fill the available space but start any larger image with a scale of below 1 to...

> I've set the container to always fill the available space, and that seems to have been enough for the zoom package to work properly with small images, though I...

1. We'd still want padding when the image is initially opened like it does right now, but if you zoom in further, the image would expand to fill the whole...

What if we were to remove the padding from the div and have the initial scale be something below 1 to make the initial image start with a margin? We'd...