Harrison Healey

Results 170 comments of Harrison Healey

@Aryakoste Yeah, please do. Once that's submitted, you can also update the package.json here to point to your branch so we can test it with the other changes for this...

I also saw the "This URL is taken" error message when I just tested on my admin account, but I see the incorrect error message on my other account, so...

Looking back further, that permission check goes back to https://github.com/mattermost/mattermost/pull/12130 which is to fix a minor security issue where guest users could figure out if a team exists using that...

That's a good point. I guess the difference here is that the `createTeam` endpoint requires stricter permissions than `teamExists`, and guests shouldn't have that permission so they'd get a "permission...

I'm not sure if this is what you were trying to fix, @komik966, but the proposal for storing the themes wouldn't quite work since we use the `name` field to...

I'd be worried that combining those all together would unfortunately cause problems. Working with a JSON object in Preferences can be tricky, particularly if we ever have to do a...

I think a separate preference for syncing would work well. We could probably do it without an extra preference like in your third option, but I like being explicit about...

> So on-by-default for anyone who has never edited their theme, off-by-default for anyone who has changed their theme before Perfect. That's the easiest option then since we can just...

Yeah, a new API for each of those would work. The body of the new methods will be mostly the same as the old ones except for the headers attached...