hmfaysal-omega-theme icon indicating copy to clipboard operation
hmfaysal-omega-theme copied to clipboard

Mixed Tag Closing Style

Open SLiNv opened this issue 7 years ago • 0 comments

Hi, Thanks for making this awesome theme! So when I was looking at index.html I found that there are mixed styles of closing a tag when a if-else statement occur. I know this is no big deal so just letting you know :wink:

for example, line 51-59, <a> tag is closed in the if/else statement

{% if post.description %}
    <a href="{{ site.url }}{{ post.url }}" data-toggle="tooltip" title="{{ post.description }}" class="more-link btn btn-danger btn-large">
        <i class="fa fa-link"></i> permalink...
    </a>
{% else %}
    <a href="{{ site.url }}{{ post.url }}" data-toggle="tooltip" title="Read more about {{ post.title }}" class="more-link btn btn-danger btn-large">
        <i class="fa fa-link"></i> permalink...
    </a>
{% endif %}

one the other hand, however, on line 132-141 <h2> is closed outside.

{% if post.link %}
    <h2 class="post-title text-center super lighter">
        <a href="{{ site.url }}{{ post.url }}" style="color: #fff; background-color: #45ADA8; border-radius: 4px; padding: 10px">
            <i class="fa fa-play-circle"></i> {{ post.title }}
        </a>
{% else %}
    <h2 class="post-title text-center super lighter bordered-bottom">
        <a href="{{ site.url }}{{ post.url }}"><i class="fa fa-play-circle"></i> {{ post.title }}</a>
{% endif %}
</h2>

SLiNv avatar Apr 14 '17 03:04 SLiNv