tessellation icon indicating copy to clipboard operation
tessellation copied to clipboard

Add support for wasm32 target & silence arithmetic error

Open indiv0 opened this issue 5 years ago • 1 comments

Hello! Thank you so much for the awesome library.

I've started using it in a game I'm developing with the Bevy engine (really all I have right is a sphere). Your library was super simple to get started with and works really well so far.

The only issue I had was rayon and std::time don't work on the wasm32 target yet so I needed to disable those to get it to work in the browser.

Adding cfg(not(target_arch = "wasm32")) everywhere the timer & rayon were used got it working for me.

indiv0 avatar Nov 19 '20 23:11 indiv0

Codecov Report

Merging #8 (d488227) into master (e1d1eec) will decrease coverage by 0.55%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   85.90%   85.35%   -0.56%     
==========================================
  Files           6        6              
  Lines         596      478     -118     
==========================================
- Hits          512      408     -104     
+ Misses         84       70      -14     
Impacted Files Coverage Δ
src/manifold_dual_contouring.rs 97.05% <ø> (+0.44%) :arrow_up:
src/mesh.rs 94.44% <0.00%> (-3.29%) :arrow_down:
src/cell_configs.rs 95.31% <0.00%> (-1.08%) :arrow_down:
src/vertex_index.rs 96.36% <0.00%> (-0.74%) :arrow_down:
src/qef.rs 73.57% <0.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1d1eec...d488227. Read the comment docs.

codecov-io avatar Nov 20 '20 00:11 codecov-io