milewski-ctfp-pdf icon indicating copy to clipboard operation
milewski-ctfp-pdf copied to clipboard

Published 20 hours ago • verified publisher icon hmemcpy

Make OCaml code samples closer to Haskell (chapters 1 to 4)

Open yawaramin opened this issue 4 years ago • 18 comments

  • Get rid of module declarations
  • Use only OCaml Stdlib
  • Rename composition operator to (%) due to operator precedence issues

yawaramin avatar Feb 20 '20 05:02 yawaramin

Even if we haven't reached a conclusion on whether we should write compilable snippets, I still think the changes in this PR, especially the ones that remove dependency on external libraries, are important. Thanks for fixing the order @yawaramin! I don't know when/how they got out of order

cc: @mseri @XVilka

ArulselvanMadhavan avatar Mar 02 '20 22:03 ArulselvanMadhavan

Thanks @ArulselvanMadhavan I can work on more chapters as well, am enjoying reading through the book.

yawaramin avatar Mar 03 '20 02:03 yawaramin

Looks much cleaner and easier to read, indeed 👍

XVilka avatar Mar 03 '20 03:03 XVilka

I agree. Looks good. Thanks @yawaramin

mseri avatar Mar 03 '20 06:03 mseri

Cheers guys, I appreciate the review 👍

yawaramin avatar Mar 03 '20 07:03 yawaramin

Will this be merged? If so I will adapt the examples accordingly in my Reason branch, too.

fhammerschmidt avatar Mar 30 '20 06:03 fhammerschmidt

Sorry for not attending to this. Are there more changes coming? Also, does this tie to the prelude discussion in #237?

hmemcpy avatar Mar 30 '20 15:03 hmemcpy

@hmemcpy hi, no problem. I've made some progress on Chapter 5 locally, if there is interest I can send more as I cover more chapters. It will be a good distraction for me from constantly obsessing over the news :-)

yawaramin avatar Mar 30 '20 15:03 yawaramin

I think a distraction would be welcomed for everybody!

hmemcpy avatar Mar 30 '20 15:03 hmemcpy

What is the current status of this MR? Is there a way to help? What about the other chapters?

francoisthire avatar May 29 '20 22:05 francoisthire

@hmemcpy would you prefer this PR to cover the whole book? Or separate PRs for a few chapters at a time?

yawaramin avatar May 29 '20 22:05 yawaramin

Hey all! So sorry for neglecting the PR! Would love to merge it. Can any of you verify there are no more changes? Unless you'd like to contribute the rest of the chapters as well?

hmemcpy avatar Sep 04 '20 17:09 hmemcpy

Hi, what's the status of this PR ?

drupol avatar May 17 '22 11:05 drupol

@yawaramin I'm reading the book right now, and I'm happy to help if you're still working on this. If not, I can take it from here and revise the rest of the chapters.

hyphenrf avatar Oct 29 '22 19:10 hyphenrf

@hyphenrf hey that would be great, please feel free. I agree with all your comments btw.

yawaramin avatar Oct 30 '22 05:10 yawaramin

Hi all,

What is the status of this PR ?

Thanks

drupol avatar Feb 02 '23 10:02 drupol

hi @drupol, I haven't finished reading the book. I have notes written all over the OCaml impl, and once I've finished the book, I'll create a patch with all the edits and which closes this PR.

hyphenrf avatar Feb 02 '23 13:02 hyphenrf

Cool, glad to see it's still alive then.

Looking forward for reviewing your pull request.

Cheers!

drupol avatar Feb 02 '23 13:02 drupol