hmdne
hmdne
While we don't call the RSpec binary in Opal-RSpec 1.1.0, the code of the executable, the rake task and the runner class have been mostly unified. Also ,we actually run...
Thanks for a great review, I will address those issues today. >Finally, you mentioned you're also working on porting Oga to Opal. Oga's codebase is much more complicated to deal...
>It seems the two commits more or less depend on each other, with the second commit ensuring changes introduced by the first pass all tests. These should just be rebased...
>That sounds extremely prone to error, so that's not something I'd merge. The converter I wrote is simple enough, but it is regexp, so it's not entirely readable. I'm pasting...
There's a small issue for opalopal as of now which regards loading of WASM modules - they can be only loaded async (at least in Chromium). I have a plan...
Other than the comment, can you add a simple test? I know encodings are a mess, but just a test to prove `n` is now accepted by Opal.
Also, take a look at the prior work on this matter: https://github.com/opal/opal/pull/2344
I kind of fail to understand what Opal::Engine does. Is it yet another wrapping solution? Wouldn't it be a better idea to split that to another PR?
Thanks for the heads up! In fact, when doing the closure tracking part, I ensured that such an expression would simply compile to `return nil`, I guess I will have...