codeowners icon indicating copy to clipboard operation
codeowners copied to clipboard

Published 20 hours ago • verified publisher icon hmarr

[bug] failed for users with dot

Open zhilyaev opened this issue 1 year ago • 2 comments

Correct

*.go @user
*.go @zhilyaev

Not Correct.

*.go @firstname.lastname
*.go @dmitrii.zhiliaev

invalid owner format '@dmitrii.zhiliaev' at position 6

zhilyaev avatar Aug 02 '23 19:08 zhilyaev

links with #13

zhilyaev avatar Aug 02 '23 19:08 zhilyaev

Same error with username with undescore. Example: *.go @firstname_lastname

yuliazarkh avatar Aug 22 '23 10:08 yuliazarkh

Now that #19 is merged, this is possible using a custom OwnerMatcher. If there's demand for a built-in set of GitLab owner matchers, I'd happily accept a PR.

hmarr avatar Jun 25 '24 14:06 hmarr