concrete-python icon indicating copy to clipboard operation
concrete-python copied to clipboard

The containers in comm_container.py should implement __contains__

Open cash opened this issue 4 years ago • 0 comments

If they don't, getitem is called twice. When using the fetch wrapper one, it ends up calling the remote service twice per request. This is because of the way CommunicationContainerFetchHandler is implemented where it first tests if the item is in the mapping and then retrieves it. Another option is to change this handler's implementation to try to access and handle the error if it is not there.

cash avatar Apr 01 '20 19:04 cash