concrete-python icon indicating copy to clipboard operation
concrete-python copied to clipboard

Remove thrift binary from Dockerfile?

Open ccmaymay opened this issue 2 years ago • 1 comments

Accelerated thrift should be installed by pip at this point. If we want the thrift binary in a container for rebuilding the concrete source, it might make more sense to have a separate Dockerfile for that (like a "runtime" Dockerfile and a "development" Dockerfile).

c.f. analogous issue in concrete-js https://github.com/hltcoe/concrete-js/issues/9

ccmaymay avatar Aug 14 '22 00:08 ccmaymay

Added a development Dockerfile containing thrift to the concrete repo: https://github.com/hltcoe/concrete/blob/main/Dockerfile

ccmaymay avatar Aug 15 '22 23:08 ccmaymay