WordPress-Plugin-Template icon indicating copy to clipboard operation
WordPress-Plugin-Template copied to clipboard

Options prefix should be set at install script

Open alantygel opened this issue 5 years ago • 1 comments

Hi,

First of all, thanks for the fabulous plugin!

Using this boilerplate for the second time, I realized that the options were being set for both plugins at the same time.

Than I found the this line:

https://github.com/hlashbrooke/WordPress-Plugin-Template/blob/27d728611ae47828dcf7fa46e0502bb9a94f6ce4/includes/class-wordpress-plugin-template-settings.php#L61

should be set to a unique prefix in order to keep the options to the right plugin.

My suggestion is to set the options prefix at the build-plugin script.

Does it make sense? If yes, I would be glad to propose this fix.

best, alan

alantygel avatar Aug 15 '19 16:08 alantygel

Hey @alantygel yes, that does make sense, and it probably should set the base from the build-plugin script.

Thanks for reporting it and please feel free to submit a pull request against develop to fix this.

jonathanbossenger avatar Aug 20 '19 14:08 jonathanbossenger