service icon indicating copy to clipboard operation
service copied to clipboard
verified publisher icon hlandau

(WIP) Replace goxsys IsAnInteractiveSession with IsWindowsService

Open JeremyRand opened this issue 4 years ago • 5 comments

Upstream goxsys deprecated IsAnInteractiveSession.

Refs https://github.com/hlandau/service/issues/17

JeremyRand avatar Mar 10 '21 12:03 JeremyRand

Actually, hmm, hold off on this for a while, might be other issues with this.

JeremyRand avatar Mar 10 '21 14:03 JeremyRand

Yeah, hmm, this breaks ncdns for reasons I am unclear on. Possibly related to the usage of a restricted service user. Will try to investigate more.

JeremyRand avatar Mar 10 '21 14:03 JeremyRand

Yeah this is not going to be fun to fix; I'll get back to you when I have more useful info. For now, leave this PR open.

JeremyRand avatar Mar 10 '21 15:03 JeremyRand

Did some debugging; upstream goxsys is ignoring a permission error in an unsafe way, which causes it to interpret restricted services as non-services. I'll look into filing a bug upstream.

JeremyRand avatar Mar 10 '21 16:03 JeremyRand

Filed upstream bug:https://github.com/golang/go/issues/44921

JeremyRand avatar Mar 11 '21 11:03 JeremyRand