shellnet icon indicating copy to clipboard operation
shellnet copied to clipboard

the variable names of qrs, pts are so misleading!

Open cam1681 opened this issue 4 years ago • 0 comments

In the paper, the authors use q to denote query points and p to denote representation points. But in the code, qrs is used to represent representation points and pts for query points. The mess makes the code very hard for comprehension for a newer like me. Hope you can change the names or give some notation in README at least. Thanks, on the behalf of the possible dazed people. I worked it out for a whole day.....

cam1681 avatar Sep 23 '20 16:09 cam1681