Helen Kershaw

- [ ] do you need the check for 0 surface pressure? https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L4600-L4606

- [ ] qc needed for obs rejected above model surface but below the lowest sigma level? https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L1158-L1178

- [ ] constants: using constants from types_mod :whale: (see https://github.com/NCAR/DART/issues/449) check this match wrf https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/assimilation_code/modules/utilities/types_mod.f90#L122 Edit also a set of constants in wrf model_mod: https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L7997-L8006 Edit2: `function compute_geometric_height` uses...

- [ ] geopotential height is using the first ensemble member only. Is this the same across the ensemble? https://github.com/NCAR/DART/blob/70e6af803a52d14b9f77f872c94b1fe11d5dc2d9/models/wrf/model_mod.f90#L2725 - [ ] The force non-negative values, are these complete?...

- [ ] shortest time between assimilations. Current code you can get 0 window size https://github.com/NCAR/DART/blob/70e6af803a52d14b9f77f872c94b1fe11d5dc2d9/models/wrf/model_mod.f90#L840-L845

For convert_vertical_obs, it looks like there is a biggish difference when you change order of calculating geometric from geopotential height. Maybe this is just a bug on my end, but...

Comments from Jeff and Moha from standup: This difference is expected and not big. For easier comparison (bitwise crutch) with existing wrf code I'm leaving in `function interpolate_geometric_height` even though...

@mjs2369 https://github.com/hkershaw-brown/DART/tree/wrf-refactor is the initial attempt, having a go at updating the wrf model_mod. It is essentially my notes about the code. I plopped it on my fork, just to...

tiny test case: /glade/work/hkershaw/tiny_wrf ``` hkershaw@derecho8:/glade/work/hkershaw/tiny_wrf$ ls check_diffs.sh main restarts wrf-refactor ``` restarts - contains the restarts main - drop in the main branch version of filter wrf-refactor - drop...

same or different qty? ``` wrf_state_variables = 'U', 'QTY_U_WIND_COMPONENT', 'TYPE_U', 'UPDATE','999', 'V', 'QTY_V_WIND_COMPONENT', 'TYPE_V', 'UPDATE','999', 'U10', 'QTY_U_WIND_COMPONENT', 'TYPE_U10','UPDATE','999', 'V10', 'QTY_V_WIND_COMPONENT', 'TYPE_V10','UPDATE','999', ```