Helen Kershaw

edit: https://github.com/hkershaw-brown/DART/tree/wrf-refactor is the initial attempt, having a go at updating the wrf model_mod https://github.com/NCAR/DART/tree/wrf-fresh is starting from scratch redoing the wrf model_mod

wrf model_mod get_close has a test for missing_r8 https://github.com/NCAR/DART/blob/72e5740b71ef6c7cde4c6f946e2c1df2019365fb/models/wrf/model_mod.f90#L6419C3-L6428 should check for verti_is_undefined before doing this (or not have the missing_r8 check)

## Vertical Convertion There are several references to the vertical location of state being converted in get_state_meta_data. This is incorrect, get_state_meta_data does not do vertical conversion. For example: https://github.com/NCAR/DART/blob/72e5740b71ef6c7cde4c6f946e2c1df2019365fb/models/wrf/model_mod.f90#L6406-L6417 get_close_obs...

To do: - [ ] wrf has a namelist option for calendar type. Are there observations not in GREGORIAN (2d?) - [ ] `variable_is_on_domain` - assuming

For VERTISLEVEL we have: https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L895-L900 bottom_top = 29 ; bottom_top_stag = 30 ; float W(Time, bottom_top_stag, south_north, west_east) ; Edit: then this: https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L1857-L1858

note in the code about latlon project settings only valid for global domains https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L7307-L7316

Mask variables: XLAND, QTY_SURFACE_TYPE Should you be interpolating a mask? edit: rounded to the nearest integer in rttov obs_def: https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/observations/forward_operators/obs_def_rttov13_mod.f90#L2065 wrf netcdf file XLAND:description = "LAND MASK (1 FOR LAND,...

I'm not sure what is not allowed here https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L6738-L6740 There are some notes in the code about periodic_x,y and polar https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L7092 It is looking like these are still wrf namelist...

Boundary condition options: The boundary conditions periodic_x,y, polar in model_mod.f90 only apply to domain 1. I guess this is why it is a namelist option rather than part of the...

Do we like the results? https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L5144 https://github.com/NCAR/DART/blob/9729d784226295a197ca3bf00c917e4aaab5003b/models/wrf/model_mod.f90#L5215