hk-independent-bus-eta icon indicating copy to clipboard operation
hk-independent-bus-eta copied to clipboard

Hide collection on list if no routes in collection

Open Hayden2018 opened this issue 1 year ago • 4 comments

Currently collections are shown under the collections tab even if no routes are in the collection, making it looks like an layout bug. This commit hide the entire collection if there are no routes in that collection. image

Hayden2018 avatar Sep 24 '23 06:09 Hayden2018

I have tried it. Would you like to add an image to instruct user how to add route to collection? Otherwise, it will be a blank page for new users, and they likely have no idea what's going on

chunlaw avatar Sep 25 '23 08:09 chunlaw

I think that make sense. For consistency sake all other tabs including "常用" or "Home" should show the same image when having no data? Maybe similar to the one in "車站" ?

Hayden2018 avatar Sep 25 '23 14:09 Hayden2018

Yes, go ahead. Suggested to prepare 4 images, each for one combination of language and color theme.

chunlaw avatar Sep 25 '23 15:09 chunlaw

Sure. Will see what i can do.

Hayden2018 avatar Sep 26 '23 15:09 Hayden2018