Book-TDD-Web-Dev-Python icon indicating copy to clipboard operation
Book-TDD-Web-Dev-Python copied to clipboard

Page 226: `lists/tests/test_model.py`

Open HelloThisIsFlo opened this issue 5 years ago • 0 comments

It's a bit confusing when you write:

item.save()
item.full_clean()

while the name of the tests is test_cannot_save_empty_list_item Because in the end... the item is saved. It can be verified by putting the following right after the with block:

self.assertEqual(Item.objects.count(), 0)

Two potential solutions

  • Maybe just swapping the order of the 2 lines might make things less confusing :)

    item.full_clean()
    item.save()
    
  • Another solution would be to simply rename the tests from test_cannot_save_empty_list_item to test_cannot_validate_empty_list_item And removing the call to save() alltogether.

HelloThisIsFlo avatar Nov 14 '19 12:11 HelloThisIsFlo