pyastar2d
pyastar2d copied to clipboard
hjweide
Moving imageio from requirements.txt to requirements-dev.txt?
Since the "imageio" package is only used in maze_solver.py example, maybe it is a good idea to ask the user to install the "imageio" individually. On the other hand, if a user is trying to use a Python version that is not supported by "imageio" (for instance, python 2 or 3.6), he/she may have trouble installing this package, and I did not see any reason this package cannot correctly run on most python versions.
Good point. I’d be okay with moving imageio to the requirements-dev.txt and updating the README to reflect that. Do you want to submit a PR for that?
But I hope not too many people are using these old Python versions anymore :)
On Thu, Jun 30, 2022 at 20:24 AnyLeftovers @.***> wrote:
Since the "imageio" package is only used in maze_solver.py https://github.com/hjweide/pyastar2d/blob/master/examples/maze_solver.py example, maybe it is a good idea to ask the user to install the "imageio" individually. On the other hand, if a user is trying to use a Python version that is not supported by "imageio" (for instance, python 2 or 3.6), he/she may have trouble installing this package, and I did not see any reason this package cannot correctly run on most python versions.
— Reply to this email directly, view it on GitHub https://github.com/hjweide/pyastar2d/issues/38, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSN6EEMQPUNW4J2PJRYPSLVRY3FVANCNFSM52LBT62A . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@hjweide Sure, I just made a pull request regarding this issue. Please review it, and thank you for giving me a chance to do so. Let me know if there are additional changes you would like me to make.
Thanks for doing this so quickly! I’ll take a look tomorrow.
On Thu, Jun 30, 2022 at 21:05 AnyLeftovers @.***> wrote:
@hjweide https://github.com/hjweide Sure, I just made the pull request regarding this issue. Please review it, and thank you for giving me a chance to do so.
— Reply to this email directly, view it on GitHub https://github.com/hjweide/pyastar2d/issues/38#issuecomment-1171815501, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSN6EC3AHT3SNUVDPCRVODVRY75FANCNFSM52LBT62A . You are receiving this because you were mentioned.Message ID: @.***>