munkiadmin icon indicating copy to clipboard operation
munkiadmin copied to clipboard

Unified Toolbar

Open chrisgrande opened this issue 8 years ago • 7 comments

This is mostly cometic, but I think makes it a little clearer. Thoughts? munkiadmin

chrisgrande avatar Mar 02 '16 19:03 chrisgrande

That's probably where MunkiAdmin is going in some future release. Is that photoshopped or did you already have the code? :smile:

hjuutilainen avatar Mar 03 '16 08:03 hjuutilainen

It's just a one-liner to fix. Create the toolbar you want, then add this:

[[self window] setTitleVisibility:NSWindowTitleHidden];

erikberglund avatar Mar 03 '16 08:03 erikberglund

Atleast, that's how i do it in the profile app: screen shot 2016-03-03 at 09 11 16

erikberglund avatar Mar 03 '16 08:03 erikberglund

Sweet, I need to look more into this. I still need to support 10.8+ for a while though and NSWindowTitleHidden is 10.10+.

hjuutilainen avatar Mar 03 '16 08:03 hjuutilainen

It's all done and working, no Photoshop it's all in the XIB no code changes. Here are the changes, https://github.com/chrisgrande/munkiadmin/commit/00790220f8cae90c3b0c8127587a2e771382d39f

chrisgrande avatar Mar 03 '16 19:03 chrisgrande

Just so I'm clear, it's effectively the same thing as doing it in code as you're settings titleVisibility but from Interface Builder: https://github.com/chrisgrande/munkiadmin/commit/00790220f8cae90c3b0c8127587a2e771382d39f#diff-4df3c56ce936d82de00142cd1d502254R258 ?

Or have you done a custom toolbar that works where titleVisibility (10.10+) isn't available? Curious as that would be nice for some other projects where I support 10.8 as well.

erikberglund avatar Mar 04 '16 13:03 erikberglund

It's basically the same as doing it in code but with the runtime attribute, on < 10.10 the toolbar will revert to the normal non unified toolbar.

chrisgrande avatar Mar 04 '16 16:03 chrisgrande