Hai Joey Tran

Results 14 comments of Hai Joey Tran

> ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/29106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > > Merging [#29106](https://app.codecov.io/gh/apache/beam/pull/29106?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ([206042e](https://github.com/apache/beam/commit/206042eb3e9529a92c13d1a050ffd89f307f6e7b)) into [master](https://app.codecov.io/gh/apache/beam/commit/38720a39d91db1853741f86d29819bf5a5d59a36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ([38720a3](https://github.com/apache/beam/commit/38720a39d91db1853741f86d29819bf5a5d59a36)) will **decrease** coverage by `33.87%`. > > Report is 446 commits behind head on master. > > The...

I ran the linting instructions here: https://cwiki.apache.org/confluence/display/BEAM/Spotless+pre-commit But they had no effect on any files

Turns out I jumped the gun and there are more than just lint failures. There were a few true tests failures that came up from actual tests that weren't actually...

I pushed test fixes and skips so we should be all set On Wed, Mar 27, 2024, 6:57 PM liferoad ***@***.***> wrote: > Turns out I jumped the gun and...

I created a spinoff issue since I think fixing the tests (which were already broken before these changes) is probably out of scope

The last commit failed with some weird pydantic/hypothesis errors that seem unrelated to these changes

Gah, I have no idea where this failure couldve come from: ``` run() File "/runner/_work/beam/beam/sdks/python/test-suites/tox/py38/build/srcs/sdks/python/target/.tox-py38-tft-113/py38-tft-113/lib/python3.8/site-packages/hypothesis/entry_points.py", line 35, in run hook = entry.load() File "/runner/_work/beam/beam/sdks/python/test-suites/tox/py38/build/srcs/sdks/python/target/.tox-py38-tft-113/py38-tft-113/lib/python3.8/site-packages/setuptools/_vendor/importlib_metadata/__init__.py", line 208, in load module =...